opt(torii/core): add explicit limit to sql query

[lambda-0x]

Even though we where already using fetch_one to only fetch a single row, its documentation says to add a limit to the query explicitly.

Summary by CodeRabbit

• New Features

  • Optimized ERC721 token registration by limiting SQL queries to fetch only a single record.
  • Enhanced error handling and logging for various query types, improving overall reliability.

• Bug Fixes

  • Adjusted transaction calculations to prevent division by zero errors.

• Improvements

  • Improved transaction management by ensuring transactions are committed only when new ones are initiated.
  • Added debug logging to track balance application operations.

[coderabbitai]

Walkthrough

Ohayo, sensei! This pull request introduces several modifications to the Executor struct within the mod.rs file. Key changes include the addition of a LIMIT 1 clause to the RegisterErc721Token query for optimized data retrieval, enhanced error handling and logging in the handle_query_message method, and refined state management for various query types. The logic for calculating transactions per second has been updated to avoid division by zero errors, and debug logging has been added to the apply_balance_diff method. Additionally, transaction management has been improved in the execute method.

Changes

File Path

Change Summary

crates/torii/core/src/executor/mod.rs

- Modified RegisterErc721Token to include LIMIT 1 in SQL query. - Enhanced error handling and logging in handle_query_message. - Refined logic for SetHead, ResetCursors, and UpdateCursors queries. - Adjusted TPS calculation to prevent division by zero. - Added debug logging to apply_balance_diff for tracking duration. - Updated execute method to commit transactions only if a new transaction is initiated.

Possibly related PRs

• fix(torii): handle failed metadata fetch and empty metadata in db #2755: The changes in this PR enhance error handling in the process_register_erc721_token_query method, which is directly related to the modifications made in the main PR regarding ERC721 token registration and metadata handling.

Suggested reviewers

• glihm

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 68999b2 and 0619eca.

📒 Files selected for processing (1)

• crates/torii/core/src/executor/mod.rs (1 hunks)

🔇 Additional comments (1)

crates/torii/core/src/executor/mod.rs (1)

617-617: Ohayo sensei! Adding LIMIT 1 to the SQL query is a good practice.

Including LIMIT 1 ensures that the query explicitly fetches only one record, aligning with the recommendations for fetch_one. This enhances clarity and may improve performance.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.36%. Comparing base (68999b2) to head (0619eca).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/torii/core/src/executor/mod.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2762      +/-   ##
==========================================
- Coverage   54.37%   54.36%   -0.01%     
==========================================
  Files         428      428              
  Lines       54201    54201              
==========================================
- Hits        29472    29469       -3     
- Misses      24729    24732       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.