-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: (readme) #2761
Docs: (readme) #2761
Conversation
The old Discord invite is invalid
WalkthroughOhayo, sensei! The recent changes in the pull request involve an update to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHub
participant DojoProject
User->>GitHub: Submits pull request
GitHub->>DojoProject: Updates CONTRIBUTING.md
DojoProject-->>GitHub: Confirms update
GitHub-->>User: Pull request merged
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
CONTRIBUTING.md (1)
101-101
: Fix grammar in the thank you messageOhayo sensei! There's a small grammar issue in the final note.
-Again, thank you for considering to contribute to Dojo. +Again, thank you for considering contributing to Dojo.🧰 Tools
🪛 LanguageTool
[grammar] ~101-~101: The verb ‘considering’ is used with the gerund form.
Context: .... ## Final Notes Again, thank you for considering to contribute to Dojo. Your contribution is invaluabl...(ADMIT_ENJOY_VB)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
CONTRIBUTING.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
CONTRIBUTING.md
[grammar] ~101-~101: The verb ‘considering’ is used with the gerund form.
Context: .... ## Final Notes Again, thank you for considering to contribute to Dojo. Your contribution is invaluabl...
(ADMIT_ENJOY_VB)
🔇 Additional comments (2)
CONTRIBUTING.md (2)
101-101
: LGTM! Changes are focused and aligned with PR objectives
Ohayo sensei! The changes are minimal and focused on updating the Discord invite link as intended. No other modifications were made to the contribution guidelines.
🧰 Tools
🪛 LanguageTool
[grammar] ~101-~101: The verb ‘considering’ is used with the gerund form.
Context: .... ## Final Notes Again, thank you for considering to contribute to Dojo. Your contribution is invaluabl...
(ADMIT_ENJOY_VB)
101-101
: Verify the new Discord invite link
Ohayo sensei! The new Discord invite link follows a more branded format which is great. However, let's ensure it's properly configured and accessible.
✅ Verification successful
Discord invite link is valid and accessible
Ohayo sensei! The new Discord invite link (https://discord.com/invite/dojoengine) is properly configured and accessible, returning a 200 OK status. The change to a more branded invite link is a good improvement.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the Discord invite link is accessible
# Expected result: HTTP 200 OK response
curl -I https://discord.com/invite/dojoengine
Length of output: 6008
🧰 Tools
🪛 LanguageTool
[grammar] ~101-~101: The verb ‘considering’ is used with the gerund form.
Context: .... ## Final Notes Again, thank you for considering to contribute to Dojo. Your contribution is invaluabl...
(ADMIT_ENJOY_VB)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch, thanks!
The old Discord invite is invalid
The old Discord invite is invalid
Description
Related issue
Tests
Added to documentation?
Checklist
scripts/prettier.sh
,scripts/rust_fmt.sh
,scripts/cairo_fmt.sh
)scripts/clippy.sh
,scripts/docs.sh
)Summary by CodeRabbit