Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(torii): add erc20 patch for eth mainnet token #2733

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

lambda-0x
Copy link
Contributor

@lambda-0x lambda-0x commented Nov 28, 2024

commit-id:93263be6


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@lambda-0x lambda-0x changed the title fix(torii): add erc20 patch for eth mainnet token fix(torii): patch for eth mainnet token Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 79 lines in your changes missing coverage. Please review.

Project coverage is 56.03%. Comparing base (6644564) to head (8752fcc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/torii/core/src/executor/erc.rs 0.00% 26 Missing ⚠️
...orii/core/src/processors/erc721_legacy_transfer.rs 0.00% 10 Missing ⚠️
...rates/torii/core/src/processors/erc721_transfer.rs 0.00% 10 Missing ⚠️
crates/torii/core/src/sql/erc.rs 0.00% 8 Missing ⚠️
...ates/torii/graphql/src/object/erc/token_balance.rs 0.00% 7 Missing ⚠️
...tes/torii/graphql/src/object/erc/token_transfer.rs 0.00% 7 Missing ⚠️
crates/torii/core/src/engine.rs 0.00% 6 Missing ⚠️
crates/torii/core/src/executor/mod.rs 0.00% 3 Missing ⚠️
...torii/core/src/processors/erc20_legacy_transfer.rs 0.00% 1 Missing ⚠️
crates/torii/core/src/processors/erc20_transfer.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2733      +/-   ##
==========================================
- Coverage   56.10%   56.03%   -0.07%     
==========================================
  Files         427      427              
  Lines       54522    54589      +67     
==========================================
+ Hits        30587    30588       +1     
- Misses      23935    24001      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

FetchDataResult::Range(range) => BlockId::Number(range.latest_block_number),
FetchDataResult::Pending(_pending) => BlockId::Tag(BlockTag::Pending),
// we dont require block_id when result is none, so this is a dummy value
FetchDataResult::None => BlockId::Number(0),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't it be more easy to maintain having an option or something? Just t be sure it's not use in a non intended manner?

But not blocking for this one, could be updated after.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, will update.

@lambda-0x lambda-0x changed the title fix(torii): patch for eth mainnet token fix(torii): add erc20 patch for eth mainnet token Dec 2, 2024
@lambda-0x lambda-0x changed the base branch from spr/main/e92e39b0 to main December 3, 2024 00:57
@lambda-0x lambda-0x merged commit 938d50f into main Dec 3, 2024
36 of 38 checks passed
@lambda-0x lambda-0x deleted the spr/main/93263be6 branch December 3, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants