-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(torii): add erc20 patch for eth mainnet token #2733
Conversation
crates/torii/core/src/engine.rs
Outdated
FetchDataResult::Range(range) => BlockId::Number(range.latest_block_number), | ||
FetchDataResult::Pending(_pending) => BlockId::Tag(BlockTag::Pending), | ||
// we dont require block_id when result is none, so this is a dummy value | ||
FetchDataResult::None => BlockId::Number(0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't it be more easy to maintain having an option or something? Just t be sure it's not use in a non intended manner?
But not blocking for this one, could be updated after.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, will update.
6d9fbee
to
c724bc4
Compare
d1c7629
to
752a88e
Compare
…ql changes commit-id:e92e39b0
commit-id:93263be6
752a88e
to
acf546b
Compare
c724bc4
to
8752fcc
Compare
commit-id:93263be6
Stack: