-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(torii): missing cli version flag #2700
Conversation
WalkthroughOhayo, sensei! This pull request introduces modifications to the Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (2)crates/torii/cli/src/args.rs (2)
The addition of the
Let's ensure the version flag works as expected with the CLI. ✅ Verification successfulLet me try a different approach to verify the version flag implementation. Version flag implementation looks correct, sensei! ✨ The code shows the version flag is properly configured in the clap derive macro with 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify that the version flag is properly recognized by the CLI parser
# Test 1: Check if --version flag is recognized in the help output
cargo run --bin torii -- --help | grep -i "version"
# Test 2: Check if -V shorthand is available (clap's default version flag)
cargo run --bin torii -- -V 2>&1 || true
# Test 3: Check if --version longhand is available
cargo run --bin torii -- --version 2>&1 || true
Length of output: 352 Script: #!/bin/bash
# Let's verify the version flag implementation in the code directly
# Check if version is properly configured in clap derive macro
ast-grep --pattern '#[command(version)]'
# Look for version-related configuration in the args.rs file
rg -A 2 'version' crates/torii/cli/src/args.rs
# Check if there are any test cases for version flag
rg -l 'test.*version' crates/torii/cli/src/
Length of output: 284 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2700 +/- ##
==========================================
+ Coverage 56.34% 56.35% +0.01%
==========================================
Files 411 411
Lines 52742 52742
==========================================
+ Hits 29719 29725 +6
+ Misses 23023 23017 -6 ☔ View full report in Codecov by Sentry. |
resolves #2699
was deleted in #2681