Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(torii-core): store update member #2182
feat(torii-core): store update member #2182
Changes from 5 commits
98801d3
3f6908e
8aba41c
65b2c39
b54901c
349b327
9dd48d8
b0d9fd5
71af001
9343249
a900617
acf7c60
8bcaf36
91949d5
7fa5f5a
8d14285
7e4c56c
6f23b9a
59736ee
98b7d48
5d8e141
ba34cd3
2e87cde
ddb37c3
ac41ee0
58eef8d
8805fa0
c6bfb58
e4a734d
1a585b5
d81a2d7
ac8b09d
14861ad
a87133d
92ec2fe
d6c939e
652a1f4
72cc8df
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohayo, Sensei! Reminder: Add tests.
The
set_model_member
function is well-implemented and crucial for updating model members. However, it lacks test coverage, which is essential for ensuring its reliability and correctness.Do you want me to generate the unit testing code or open a GitHub issue to track this task?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Robust implementation of
set_model_member
.The function is well-implemented and crucial for updating model members. However, it lacks test coverage, which is essential for ensuring its reliability and correctness.
+ // TODO: Add unit tests to cover `set_model_member`.
Would you like assistance in creating unit tests for this function, or should I open a GitHub issue to track this task?
Committable suggestion
Tools
GitHub Check: codecov/patch