Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V7 Backports #823

Merged
merged 4 commits into from
Jul 22, 2020
Merged

V7 Backports #823

merged 4 commits into from
Jul 22, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Jul 22, 2020

Type: feature

The following has been addressed in the PR:

Description:

Backports of #802, #812 and #818

maier49 and others added 3 commits July 22, 2020 15:15
Change insertBefore/After to allow any template children rather than typing based on the targeted node.
* failing unit test for nested body and head tags

* skip head or body node when finding insert before node
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 577ddc1:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #823 into v7 will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v7     #823   +/-   ##
=======================================
  Coverage   97.52%   97.53%           
=======================================
  Files         126      126           
  Lines        7933     7936    +3     
  Branches     1826     1827    +1     
=======================================
+ Hits         7737     7740    +3     
  Misses        196      196           
Impacted Files Coverage Δ
src/testing/renderer.ts 97.58% <ø> (ø)
src/core/vdom.ts 97.98% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ca5ed...577ddc1. Read the comment docs.

@agubler agubler merged commit df6cb54 into dojo:v7 Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants