-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to TS 3.8 #719
Upgrade to TS 3.8 #719
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 690a0e6:
|
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
==========================================
+ Coverage 97.76% 97.78% +0.02%
==========================================
Files 120 121 +1
Lines 6974 7052 +78
Branches 1585 1603 +18
==========================================
+ Hits 6818 6896 +78
Misses 156 156
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions, doesn't look overly complicated so far.
package.json
Outdated
@@ -86,7 +86,7 @@ | |||
"rimraf": "~2.6.2", | |||
"selenium-webdriver": "3.6.0", | |||
"sinon": "~4.1.3", | |||
"typescript": "3.4.5" | |||
"typescript": "3.8.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to change the version, we are mostly trying to make the package forwards compatible. Is that possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that was just my misunderstanding. I've reverted the package version, still builds fine against 3.4.5
This worked with the |
Type: feature
The following has been addressed in the PR:
prettier
as per the readme code style guidelinesDescription:
Resolves #718