Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow .pcss as a extension for postcss files #97

Closed
wants to merge 1 commit into from

Conversation

lucidlemon
Copy link

This would allow css files to not only end in .m.css and .css but also .m.pcss and .pcss in order to interpret postcss files as such within the IDE.

I hope these changes are 100% correct, for some reason there are a total of 7 definitions for .css files in here - is this intended?

As this shouldn't break existing code I guess this could be merged quite quickly.

This would allow css files to not only end in `.m.css` and `.css` but also `.m.pcss` and `.pcss` in order to interpret postcss files as such within the IDE.

I hope these changes are 100% correct, for some reason there are a total of 7 definitions for .css files in here - is this intended?
@jsf-clabot
Copy link

jsf-clabot commented May 17, 2018

CLA assistant check
All committers have signed the CLA.

@lucidlemon
Copy link
Author

Also kinda solves #89.

@codecov
Copy link

codecov bot commented May 17, 2018

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   68.07%   68.07%           
=======================================
  Files           8        8           
  Lines         332      332           
  Branches       59       59           
=======================================
  Hits          226      226           
  Misses        101      101           
  Partials        5        5
Impacted Files Coverage Δ
src/base.config.ts 34.84% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5abddb0...69d07e1. Read the comment docs.

@lucidlemon
Copy link
Author

why is a merge request failing if the codecov stays exactly the same? 🤔

@dylans
Copy link
Member

dylans commented May 17, 2018

why is a merge request failing if the codecov stays exactly the same? 🤔

It was running the tests when you checked.

@dylans
Copy link
Member

dylans commented May 17, 2018

Please see my last two notes in #89. I'd like to make 100% certain we're fixing this in the right place and fully understand the problem before we land this. Also note that we would need to also solve this for cli-build-widget as well, assuming we go this route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants