Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for On Demand BTR #388

Merged
merged 4 commits into from
Apr 17, 2020
Merged

Support for On Demand BTR #388

merged 4 commits into from
Apr 17, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Apr 17, 2020

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR
  • schema.json has been updated appropriately

Description:

Uses the on demand BTR middleware from webpack-contrib and turns the mode on when using btr in build and watch.

Resolves #367

@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #388 into master will decrease coverage by 0.19%.
The diff coverage is 82.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   48.51%   48.32%   -0.20%     
==========================================
  Files          10       10              
  Lines         707      716       +9     
  Branches      206      213       +7     
==========================================
+ Hits          343      346       +3     
- Misses        364      370       +6     
Impacted Files Coverage Δ
src/base.config.ts 19.24% <0.00%> (ø)
src/dev.config.ts 18.33% <0.00%> (-0.32%) ⬇️
src/dist.config.ts 27.27% <0.00%> (-0.42%) ⬇️
src/main.ts 87.50% <89.18%> (-1.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff4deed...f290f5b. Read the comment docs.

@agubler agubler merged commit d465226 into dojo:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support conditionally running single BTR pages on request in watch/serve
2 participants