Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure webpack still emits on errors #245

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Conversation

agubler
Copy link
Member

@agubler agubler commented Feb 13, 2019

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Change configuration so that webpack still emits on errors in order to ensure that manifest plugin will correctly emit a manifest file after an error'd build.

Resolves #244

@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #245 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   52.67%   52.52%   -0.16%     
==========================================
  Files          10       10              
  Lines         617      615       -2     
  Branches      155      155              
==========================================
- Hits          325      323       -2     
  Misses        292      292
Impacted Files Coverage Δ
src/main.ts 90.64% <ø> (-0.11%) ⬇️
src/base.config.ts 23.16% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dc6638...1e367bb. Read the comment docs.

@agubler agubler merged commit 8baa44f into dojo:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants