Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support Node during Build Time Render #221

Merged
merged 4 commits into from
Dec 13, 2018

Conversation

matt-gadd
Copy link
Contributor

Type: feature

The following has been addressed in the PR:

  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:
Changes to support dojo/webpack-contrib#100

@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #221 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
- Coverage   53.73%   53.64%   -0.09%     
==========================================
  Files          10       10              
  Lines         603      604       +1     
  Branches      147      147              
==========================================
  Hits          324      324              
- Misses        279      280       +1
Impacted Files Coverage Δ
src/dist.config.ts 33.33% <0%> (-0.57%) ⬇️
src/dev.config.ts 21.15% <0%> (ø) ⬆️
src/base.config.ts 21.96% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 816be74...42da32a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #221 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
- Coverage   53.73%   53.64%   -0.09%     
==========================================
  Files          10       10              
  Lines         603      604       +1     
  Branches      147      147              
==========================================
  Hits          324      324              
- Misses        279      280       +1
Impacted Files Coverage Δ
src/dist.config.ts 33.33% <0%> (-0.57%) ⬇️
src/dev.config.ts 21.15% <0%> (ø) ⬆️
src/base.config.ts 21.96% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 816be74...42da32a. Read the comment docs.

@matt-gadd matt-gadd merged commit 7c3708e into dojo:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants