Include assets from "assets/" directory #126
Conversation
README.md
Outdated
| @@ -132,6 +132,10 @@ An array of paths to [CLDR JSON](https://github.com/dojo/i18n#loading-cldr-data) | |||
| } | |||
| ``` | |||
|
|
|||
| #### `copyPublicAssets`: boolean | |||
There was a problem hiding this comment.
Do we really need a flag for this given we can just presume if they have/haven’t a public folder they’re opting in/out?
There was a problem hiding this comment.
On second thought, I suppose we do not.
|
I think we are going to release this in the next major (under a group of enhancements), so I think this needs to be raised against the |
Add a `copyPublicAssets` build flag used to determine whether files in an optional `public/` directory should be copied to the output directory.
mwistrand
force-pushed
the
125-public-assets
branch
from
9a0230a
to
faddeac
Compare
Codecov Report
@@ Coverage Diff @@
## next #126 +/- ##
==========================================
- Coverage 60.53% 59.76% -0.77%
==========================================
Files 8 8
Lines 413 425 +12
Branches 91 93 +2
==========================================
+ Hits 250 254 +4
- Misses 163 171 +8
Continue to review full report at Codecov.
|
|
@mwistrand can we put a feature in for the |
|
example for above: say an image tag with a src to the public directory? |
Add a `publicDir` build option that defaults to "public" but can be overridden in the event that the server handles the "public" directory in an undesirable manner.
mwistrand
force-pushed
the
125-public-assets
branch
from
80a0578
to
7a86a5d
Compare
mwistrand
changed the title
Copy (without hashing) all files in the `assets` directory to the `output/{mode}/assets` directory.
Copy (without hashing) all files in the `assets` directory to the `output/{mode}/assets` directory.
Resolves #125. Add a
copyPublicAssetsbuild flag used to determine whether files inan optional
public/directory should be copied to the outputdirectory.