Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[d3d9] SIMPLIFIED: Only dirty frame buffer on render state changes if render area is impacted #4358

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

K0bin
Copy link
Collaborator

@K0bin K0bin commented Oct 13, 2024

Simplified version of #4349 that removes some tracking.
It removes some more tracking that has kind of bothered me.

@doitsujin
Copy link
Owner

I like this approach more, however I think we need to do two passes over the render target array:

  • one to determine the actual render area from only actively written RTV/DSV
  • one to filter out non-written RTV/DSV that are actually smaller than the render area

Otherwise we'll filter out false positives, especially if an active DSV is what actually limits the render area.

@K0bin K0bin force-pushed the colorwritemask-opt-smol branch from 79c07b3 to 79e14e8 Compare October 13, 2024 14:51
@K0bin K0bin force-pushed the colorwritemask-opt-smol branch from 79e14e8 to e6b5951 Compare October 13, 2024 15:11
@doitsujin doitsujin merged commit f65897b into doitsujin:master Oct 13, 2024
3 checks passed
@K0bin K0bin deleted the colorwritemask-opt-smol branch October 13, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants