Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pki-server password-set/unset #4935

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Add pki-server password-set/unset #4935

merged 1 commit into from
Jan 24, 2025

Conversation

edewata
Copy link
Contributor

@edewata edewata commented Jan 23, 2025

The pki-server password-set/unset have been added to replace pki-server password-add/del for managing the passwords in password.conf.

The pki-server password-add will only work if the password does not exist already, whereas the pki-server password-set will overwrite the existing password.

The pki-server password-set will also support reading the password from file and from console.

https://github.com/edewata/pki/blob/refs/heads/cli/docs/changes/v11.6.0/Tools-Changes.adoc#add-pki-server-pki-server-password-setunset

@edewata edewata requested a review from fmarco76 January 23, 2025 22:58
@edewata edewata force-pushed the cli branch 2 times, most recently from 795bf64 to 7eef411 Compare January 24, 2025 00:27
The pki-server password-set/unset have been added to replace
pki-server password-add/del for managing the passwords in
password.conf.

The pki-server password-add will only work if the password
does not exist already, whereas the pki-server password-set
will overwrite the existing password.

The pki-server password-set will also support reading the
password from file and from console.
Copy link
Member

@fmarco76 fmarco76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edewata
Copy link
Contributor Author

edewata commented Jan 24, 2025

@fmarco76 Thanks!

@edewata edewata merged commit 550b2c1 into dogtagpki:master Jan 24, 2025
164 of 171 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants