Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup of button click bug #47

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Fixup of button click bug #47

merged 2 commits into from
Sep 20, 2023

Conversation

Kumpello
Copy link
Contributor

It seems to fix Bubble touch not working properly #40 without any issues

@dofire
Copy link
Owner

dofire commented Sep 19, 2023 •
edited
Loading

Hi @Kumpello 👋, Thank you for your PR but it doesn't seem to solve the issue, I've mentioned about it here

@Kumpello
*revert
305df5a 
*fix of ignoreChildClickEvent
@Kumpello
Copy link
Contributor Author

Hi @Kumpello 👋, Thank you for your PR but it doesn't seem to solve the issue, I've mentioned about it here

Hi, thanks for checking it. I think i fixed it up now.

@Kumpello Kumpello changed the title *Changes onTouchListener to doOnTouchEvent if force dragging is disabled Fixup of button click bug Sep 19, 2023
@dofire dofire changed the base branch from release/v0.6.2 to develop September 20, 2023 10:03
@dofire dofire changed the base branch from develop to master September 20, 2023 10:54
@dofire dofire merged commit 14b6fb6 into dofire:master Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kumpello @dofire