Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Add support for views #20

Merged
merged 6 commits into from
Nov 25, 2024
Merged

* Add support for views #20

merged 6 commits into from
Nov 25, 2024

Conversation

ag-ramachandran
Copy link
Contributor

  • Add support for Views/Functions apart from Materialized views
  • Facilitate local development adding support for AZ CLI based auth
  • Upgrade Kusto libraries to latest version

@martingrin
Copy link

@ag-ramachandran hey! We'll see in about a week

@pa1ch
Copy link
Contributor

pa1ch commented Nov 21, 2024

@ag-ramachandran hi! Thank you for your PR. Could you add some unit tests for the new functionality?

@ag-ramachandran
Copy link
Contributor Author

@ag-ramachandran hi! Thank you for your PR. Could you add some unit tests for the new functionality?

Hello @pa1ch , done. Added tests for both the AZCLI based auth scenarios and also for the views addition.

pa1ch
pa1ch previously approved these changes Nov 22, 2024
@pa1ch
Copy link
Contributor

pa1ch commented Nov 22, 2024

@ag-ramachandran fix pylint errors please.

************* Module sqlalchemy_kusto.dialect_base
sqlalchemy_kusto/dialect_base.py:142:8: C0103: Variable name "mv" doesn't conform to snake_case naming style (invalid-name)

@ag-ramachandran
Copy link
Contributor Author

@ag-ramachandran fix pylint errors please.

************* Module sqlalchemy_kusto.dialect_base
sqlalchemy_kusto/dialect_base.py:142:8: C0103: Variable name "mv" doesn't conform to snake_case naming style (invalid-name)

Hello @pa1ch , Fixed the formatting lint. Would you know why this fails

4. Run mypy for type checking.
.venv/bin/python -m mypy .
.venv/lib/python3.8/site-packages/_pytest/python.py:918: error: f-string: self documenting expressions are only supported in Python 3.8 and greater  [syntax]
Found 1 error in 1 file (errors prevented further checking)
make: *** [Makefile:39: check] Error 2
Error: Process completed with exit code 2.

@pa1ch
Copy link
Contributor

pa1ch commented Nov 25, 2024

@ag-ramachandran thank you for fix. I fixed mypy error

@pa1ch pa1ch merged commit 50cbdab into dodopizza:main Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants