Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctrl+enter/cmd+enter keyboard shortcut to submit code from editor #5646

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jun 25, 2024

This pull request adds the keyboard shortcut Ctrl-Enter (and cmd+enter on mac) for submitting from the editor.

Closes #3564

@jorg-vr jorg-vr added the enhancement A change that isn't substantial enough to be called a feature label Jun 25, 2024
@jorg-vr jorg-vr self-assigned this Jun 25, 2024
@jorg-vr jorg-vr requested a review from bmesuere as a code owner June 25, 2024 14:54
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it always ctrl, or will it use cmd on mac (which is the behaviour we want)?

@jorg-vr
Copy link
Contributor Author

jorg-vr commented Jun 26, 2024

According to the docs, the 'Mod' keyword should map to cmd on mac and ctrl on other systems. (But I haven't tested in on mac)

@jorg-vr jorg-vr requested a review from bmesuere June 26, 2024 07:13
@bmesuere bmesuere changed the title Submit on Ctrl-Enter keyboard shortcut Add ctrl+enter/cmd+enter keyboard shortcut to submit code from editor Jun 26, 2024
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I updated the title

@jorg-vr jorg-vr merged commit 6b2ceb3 into main Jun 26, 2024
14 of 15 checks passed
@jorg-vr jorg-vr deleted the enhance/ctrl-enter-run branch June 26, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run code keyboard shortcut
2 participants