Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix series indicator on course page #5561

Merged
merged 3 commits into from
May 31, 2024
Merged

Fix series indicator on course page #5561

merged 3 commits into from
May 31, 2024

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented May 31, 2024

This pull request fixes the correct series indicator being shown as active on the course page.

Probably a change in the series card structure caused this to fail.

Closes #5560.

jorg-vr added 2 commits May 31, 2024 15:17
@jorg-vr jorg-vr added the bug Something isn't working label May 31, 2024
@jorg-vr jorg-vr self-assigned this May 31, 2024
@jorg-vr jorg-vr marked this pull request as ready for review May 31, 2024 13:49
@jorg-vr jorg-vr requested a review from a team as a code owner May 31, 2024 13:49
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team May 31, 2024 13:49
app/assets/javascripts/scrollspy.ts Outdated Show resolved Hide resolved
@jorg-vr jorg-vr requested a review from bmesuere May 31, 2024 14:18
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't even know closest existed :)

@jorg-vr jorg-vr merged commit 5a69821 into main May 31, 2024
13 checks passed
@jorg-vr jorg-vr deleted the fix/indicator-broken branch May 31, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exercise series indicator is broken
3 participants