Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exercise name for dolos report #5530

Merged
merged 5 commits into from
May 16, 2024
Merged

Use exercise name for dolos report #5530

merged 5 commits into from
May 16, 2024

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented May 14, 2024

This pull request makes it so that for all exports, if only one option (eg. course, series, exercise) is selected, the name of that option is used for the exported file.

I have also removed the .zip extension in the name of the dolos report.

Closes #5525

@jorg-vr jorg-vr added the bug Something isn't working label May 14, 2024
@jorg-vr jorg-vr self-assigned this May 14, 2024
@jorg-vr jorg-vr requested a review from a team as a code owner May 14, 2024 14:27
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team May 14, 2024 14:27
app/assets/javascripts/i18n/translations.json Outdated Show resolved Hide resolved
app/helpers/export_helper.rb Outdated Show resolved Hide resolved
@jorg-vr jorg-vr requested a review from bmesuere May 16, 2024 07:59
@bmesuere bmesuere requested review from niknetniko and removed request for chvp May 16, 2024 08:14
@jorg-vr jorg-vr merged commit 0889c45 into main May 16, 2024
12 of 13 checks passed
@jorg-vr jorg-vr deleted the fix/export-name branch May 16, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use exercise name for plagiarism report
3 participants