Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump glightbox from 3.2.0 to 3.3.0 #5469

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 1, 2024

Bumps glightbox from 3.2.0 to 3.3.0.

Changelog

Sourced from glightbox's changelog.

3.3.0

  • New: glightbox types #411
  • New: extend provider regex for ytb shorts #404
  • Fixed: Fix height calculation for lightbox with description and height set #426
  • Fixed: Don't set any font-family #424
Commits
  • 776a7cb Updated version number
  • 4fd15bf Updated changelog
  • 2f57221 Merge pull request #404 from tomasvn/feature/395_ytb-shorts
  • 5090c72 Merge branch 'master' into feature/395_ytb-shorts
  • bb980f9 Merge pull request #424 from felixranesberger/master
  • eb4ff35 Merge pull request #411 from tomasvn/feature/405_glightbox-types
  • f11c60c Merge pull request #426 from felixranesberger/fix-description-height-issue
  • 8788b4f Update stale.yml
  • c0e5580 Merge pull request #446 from peterryan/fix/typos
  • d8babc3 Fix minor typos in README and CONTRIBUTING
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [glightbox](https://github.com/biati-digital/glightbox) from 3.2.0 to 3.3.0.
- [Release notes](https://github.com/biati-digital/glightbox/releases)
- [Changelog](https://github.com/biati-digital/glightbox/blob/master/CHANGELOG.md)
- [Commits](biati-digital/glightbox@3.2.0...3.3.0)

---
updated-dependencies:
- dependency-name: glightbox
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from jorg-vr as a code owner April 1, 2024 12:02
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 1, 2024
@jorg-vr
Copy link
Contributor

jorg-vr commented Apr 2, 2024

I would skip this update.

The typescript changes in biati-digital/glightbox#411 are not ideal.

open(element: Element, startAt: number) now has required arguments, even though the underlying js doesn't require these.

Providing both with null, as is the default, caused new errors which I couldn't immediately solve.
And I am not sure it is worth it to try to fix those issues as the author is working on a completely new 4.0 version biati-digital/glightbox#472

@bmesuere bmesuere closed this Apr 2, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Apr 2, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/glightbox-3.3.0 branch April 2, 2024 09:58
@tomasvn
Copy link

tomasvn commented Aug 31, 2024

@jorg-vr I have opened a new PR to fix those issues with types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants