Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tips that nudge users to better use of Dodona #5386

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Feb 26, 2024

This pull request introduces user tips in Dodona. These tips are meant to nudge users in the right direction, so they can make use of Dodona in the most optimal way.

image
For the above notice I had to introduce a database column that tracks if a judge is deprecated
image

image
image
These notices are dynamically added or removed when changing the number of exercises.

image

Closes #5335

@jorg-vr jorg-vr added the feature New feature or request label Feb 26, 2024
@jorg-vr jorg-vr self-assigned this Feb 26, 2024
@jorg-vr jorg-vr marked this pull request as ready for review February 26, 2024 09:50
@jorg-vr jorg-vr requested a review from a team as a code owner February 26, 2024 09:50
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team February 26, 2024 09:50
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think it's important to update the series tip dynamically. We want to inform people when they are adding a lot of exercises and make them think twice at that moment. If we only show it on page load, there a big chance they won't even see the message and if they do, it might already be too late.

config/locales/views/activities/en.yml Outdated Show resolved Hide resolved
@jorg-vr
Copy link
Contributor Author

jorg-vr commented Feb 28, 2024

I have updated them to be dynamic

@jorg-vr jorg-vr requested a review from bmesuere February 28, 2024 15:16
@jorg-vr jorg-vr merged commit 683c5a6 into main Feb 28, 2024
11 of 13 checks passed
@jorg-vr jorg-vr deleted the feat/nudge-users branch February 28, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nudge users in the right direction with info messages
3 participants