Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop previous papyros execution on new debug run #5362

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Feb 13, 2024

This pull request fixes #5361

I will refactor this in papyros so we only need await papyros.codeRunner.stop(); on the dodona side. But decided to already push this now to fix the bug.

Closes #5361

@jorg-vr jorg-vr added the bug Something isn't working label Feb 13, 2024
@jorg-vr jorg-vr self-assigned this Feb 13, 2024
@jorg-vr jorg-vr requested a review from a team as a code owner February 13, 2024 12:43
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team February 13, 2024 12:43
app/assets/javascripts/tutor.ts Outdated Show resolved Hide resolved
app/assets/javascripts/tutor.ts Outdated Show resolved Hide resolved
@jorg-vr jorg-vr merged commit 87c0496 into main Feb 13, 2024
12 of 13 checks passed
@jorg-vr jorg-vr deleted the fix/previous-execution branch February 13, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should stop previous papyros execution before starting a new one
2 participants