-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make copy course button more prominent for featured courses #5360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
added
the
enhancement
A change that isn't substantial enough to be called a feature
label
Feb 12, 2024
jorg-vr
requested review from
bmesuere and
niknetniko
and removed request for
a team
February 12, 2024 16:51
niknetniko
approved these changes
Feb 12, 2024
Co-authored-by: Niko Strijbol <[email protected]>
Co-authored-by: Niko Strijbol <[email protected]>
bmesuere
approved these changes
Feb 12, 2024
Co-authored-by: Bart Mesuere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the copy course button more prominent for featured courses.
Featured courses are mainly used as templates for teachers. It thus makes sense to make copying such a course the primary highlighted action for teachers.
The copy course card replaces the subscribe card for teachers. The subscribe button is moved to same location as the unsubscribe location.
This allowed me to make use of this space in the card to add some extra information for new teachers and redirect them to our documentation.