Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make team explicit and add publications page #5162

Merged
merged 10 commits into from
Nov 16, 2023
Merged

Make team explicit and add publications page #5162

merged 10 commits into from
Nov 16, 2023

Conversation

chvp
Copy link
Member

@chvp chvp commented Nov 16, 2023 •
edited
Loading

Fixes #4092.

Publications are listed in reverse chronological order. Titles and abstracts are kept in English for both the Dutch and English versions of the pages.

@chvp chvp added the enhancement A change that isn't substantial enough to be called a feature label Nov 16, 2023
@chvp chvp force-pushed the feat/publications-page branch from 962ed05 to 7df1a43 Compare November 16, 2023 12:05
@chvp chvp force-pushed the feat/publications-page branch from 2a1ea29 to 4721c22 Compare November 16, 2023 12:36
@chvp chvp marked this pull request as ready for review November 16, 2023 13:06
@chvp chvp requested a review from a team as a code owner November 16, 2023 13:06
@chvp chvp requested review from bmesuere and jorg-vr and removed request for a team November 16, 2023 13:06
niknetniko
niknetniko requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@niknetniko niknetniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a link somewhere to the actual papers?

@chvp chvp requested a review from niknetniko November 16, 2023 13:27
@chvp chvp force-pushed the feat/publications-page branch from 7d84d4a to 219c35d Compare November 16, 2023 13:39
@bmesuere bmesuere added the deploy mestra Request a deployment on mestra label Nov 16, 2023
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Nov 16, 2023
bmesuere
bmesuere requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more links to the publication page:

  • signed out nav bar
  • signed out home page
  • about page

Instead of floating the image, I would use a col class. This will also add some padding between text and image + provide a better small screen experience.

@chvp chvp requested a review from bmesuere November 16, 2023 14:46
@chvp chvp enabled auto-merge November 16, 2023 15:39
@chvp chvp merged commit 75dc25b into main Nov 16, 2023
13 checks passed
@chvp chvp deleted the feat/publications-page branch November 16, 2023 15:53
@bmesuere bmesuere added feature New feature or request and removed enhancement A change that isn't substantial enough to be called a feature labels Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorg-vr jorg-vr jorg-vr approved these changes

@niknetniko niknetniko niknetniko approved these changes

@bmesuere bmesuere bmesuere approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add publication page
4 participants
@chvp @bmesuere @niknetniko @jorg-vr