Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feedback table crash when there are no groups #5131

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Conversation

bmesuere
Copy link
Member

This pull request handles the case where the feedback table contains no groups and crashes because of that:

undefined method 'count' for nil:NilClass
   groups_correct = t[:groups].count { |g| g[:accepted] }

Next to handling the nil, I now also hide the summary in that case.

@bmesuere bmesuere added the bug Something isn't working label Nov 12, 2023
@bmesuere bmesuere requested a review from a team as a code owner November 12, 2023 15:51
@bmesuere bmesuere requested review from niknetniko, jorg-vr and chvp and removed request for a team November 12, 2023 15:51
@bmesuere bmesuere merged commit 4740c7e into main Nov 12, 2023
14 of 15 checks passed
@bmesuere bmesuere deleted the fix/feedback-table branch November 12, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants