Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add uniqueness validation to repository remote url" #5121

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Revert "Add uniqueness validation to repository remote url" #5121

merged 1 commit into from
Nov 8, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Nov 8, 2023

Reverts #5118

I will revert this for now because:

  • it is broken on naos as some non unique values still exist
  • it will still be broken on production as well as the non unique values noticed on naos are different from those fixed on production. These need to be verified and fixed in production first
  • deploying the backup to naos is also broken, which should be fixed bfore this can be fixed properly
  • Reverting this allows more important fixes to be roaaled out first (Ufora bug seems more urgent than this)

@jorg-vr jorg-vr added the bug Something isn't working label Nov 8, 2023
@jorg-vr jorg-vr self-assigned this Nov 8, 2023
@jorg-vr jorg-vr requested a review from a team as a code owner November 8, 2023 13:42
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team November 8, 2023 13:42
@jorg-vr jorg-vr merged commit 3dff0c5 into main Nov 8, 2023
15 checks passed
@jorg-vr jorg-vr deleted the revert-5118-fix/unique_clone_url branch November 8, 2023 13:52
@jorg-vr jorg-vr mentioned this pull request Nov 10, 2023
Merged
4 tasks
@bmesuere bmesuere added the no-release-notes Pull requests that should not show up in release notes label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmesuere bmesuere bmesuere approved these changes

@niknetniko niknetniko Awaiting requested review from niknetniko niknetniko was automatically assigned from dodona-edu/review

Assignees

@jorg-vr jorg-vr

Labels
bug Something isn't working no-release-notes Pull requests that should not show up in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorg-vr @bmesuere