Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blur potentially sensitive info while in anonymous mode #5083

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

bmesuere
Copy link
Member

This pull request blurs some exercise names while in anonymous mode to prevent sensitive information from leaking. Currently, the blur is applied to:

  • recent exercises
  • draft exercises
  • exercises in hidden series on the course page

The blur is applied by adding a css class that adds a blur using a filter. When you hover over the element, the blur disapprears.

This feature was implemented after @pdawyndt voiced his concern that the name of exam/evaluation exercises might be leaked to students when using Dodona while projecting. The addition of draft exercises on the homepage worsens this concern.

You could argue that "jump back in" and recent exercises in courses should also be blurred, but then the homepage becomes hard to read. I think we now blur the most likely candidates.

Note that we keep struggling with finding an accurate name for demo mode/anonymous mode.

image
image

@bmesuere bmesuere added the enhancement A change that isn't substantial enough to be called a feature label Oct 26, 2023
@bmesuere bmesuere requested a review from a team as a code owner October 26, 2023 13:21
@bmesuere bmesuere requested review from niknetniko and jorg-vr and removed request for a team October 26, 2023 13:21
Base automatically changed from feat/add-draft-flag to main October 26, 2023 14:08
@jorg-vr jorg-vr merged commit f65dceb into main Oct 26, 2023
12 of 13 checks passed
@jorg-vr jorg-vr deleted the feature/blur-private-info branch October 26, 2023 14:45
@jorg-vr jorg-vr temporarily deployed to naos October 26, 2023 14:45 — with GitHub Actions Inactive
@jorg-vr jorg-vr temporarily deployed to production October 26, 2023 14:50 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants