Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor right request index from table to card list view #5061

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Refactor right request index from table to card list view #5061

merged 1 commit into from
Oct 23, 2023

Conversation

bmesuere
Copy link
Member

This pull request refactors the right request index page from a table to a card list view. The main upside is that the mobile view is now a lot better which is important since I approve most requests from my phone. There are 2 functional changes:

  • When approving/rejecting, the index isn't reloaded anymore. Instead "approved" or "rejected" is shown instead of the buttons.
  • There is now a confirmation before rejection (to prevent accidental rejects on a phone)

Before:
image
image

After:
image
image

@bmesuere bmesuere added the enhancement A change that isn't substantial enough to be called a feature label Oct 22, 2023
@bmesuere bmesuere requested a review from a team as a code owner October 22, 2023 11:40
@bmesuere bmesuere requested review from niknetniko and jorg-vr and removed request for a team October 22, 2023 11:40
@bmesuere bmesuere merged commit 927894a into main Oct 23, 2023
15 checks passed
@bmesuere bmesuere deleted the enhancement/right-request branch October 23, 2023 07:39
@bmesuere bmesuere temporarily deployed to naos October 23, 2023 07:39 — with GitHub Actions Inactive
@bmesuere bmesuere temporarily deployed to production October 23, 2023 07:43 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorg-vr jorg-vr jorg-vr approved these changes

@niknetniko niknetniko Awaiting requested review from niknetniko niknetniko was automatically assigned from dodona-edu/review

Assignees
No one assigned
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmesuere @jorg-vr