-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow python tutor for every judge #5050
Conversation
@niknetniko you can test your Tested implementation using this pr if you also run https://github.com/dodona-edu/python-tutor-webservice locally. if you have a better suggestion for the fields I am open to that. Then I will simply add support for both and put the new names in the docs. |
Summary of my changes:
See dodona-edu/universal-judge#449 for the implementation in TESTed. |
import { initFileViewers } from "file_viewer"; | ||
|
||
window.dodona.initPythiaSubmissionShow = initPythiaSubmissionShow; | ||
|
||
// will automatically bind to window.iFrameResize() | ||
require("iframe-resizer"); // eslint-disable-line no-undef | ||
window.dodona.initFileViewers = initFileViewers; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since only the file viewer is left in this pack, wouldn't it be a good time to eliminate it and just add the file viewer init to the general submission pack and the initialisation code to the general feedback table renderer?
This pull request allows the python tutor for every judge.
If a test case contains the following:
A link to the python tutor is added.
For pythia
"files": {} // Map of names to their contents and other metadata, ignored for now.
is also still supported, both to init file links and for the tutor.It is not yet generalized as Tested is not yet ready to support it.
We will add this support in a future pr.