Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix annotating part of a line #4990

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix annotating part of a line #4990

merged 1 commit into from
Sep 20, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Sep 20, 2023

This pull request fixes creating an annotation for a subselection of a line.

this was broken since #4959

@jorg-vr jorg-vr added the bug Something isn't working label Sep 20, 2023
@jorg-vr jorg-vr requested a review from a team as a code owner September 20, 2023 11:31
@jorg-vr jorg-vr self-assigned this Sep 20, 2023
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team September 20, 2023 11:31
bmesuere
bmesuere approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the fix, but it still doesn't look very robust and is hard to test.

@jorg-vr jorg-vr merged commit e702023 into main Sep 20, 2023
14 of 15 checks passed
@jorg-vr jorg-vr deleted the fix/select-word branch September 20, 2023 12:05
@jorg-vr jorg-vr temporarily deployed to naos September 20, 2023 12:05 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niknetniko niknetniko niknetniko approved these changes

@bmesuere bmesuere bmesuere approved these changes

Assignees

@jorg-vr jorg-vr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorg-vr @bmesuere @niknetniko