Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Replace Ace Editor with CodeMirror" #4962

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

niknetniko
Copy link
Member

Reverts #4933

@niknetniko niknetniko requested review from jorg-vr and a team as code owners September 12, 2023 12:30
@niknetniko niknetniko requested review from bmesuere and removed request for a team September 12, 2023 12:30
Copy link
Contributor

@jorg-vr jorg-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exercise page was broken for at least some pages in production.
Example of failing exercise: https://dodona.be/en/courses/1662/series/18522/activities/665852271/#submission-card

@jorg-vr jorg-vr merged commit 4140bee into main Sep 12, 2023
12 of 13 checks passed
@jorg-vr jorg-vr deleted the revert-4933-enhance/codemirror branch September 12, 2023 12:42
@jorg-vr jorg-vr temporarily deployed to naos September 12, 2023 12:42 — with GitHub Actions Inactive
@jorg-vr jorg-vr temporarily deployed to production September 12, 2023 12:46 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants