Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid crash when calling a delayed job on a deleted question #4847

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Avoid crash when calling a delayed job on a deleted question #4847

merged 3 commits into from
Jul 28, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jul 27, 2023

Closes #4696

@jorg-vr jorg-vr added the bug Something isn't working label Jul 27, 2023
@jorg-vr jorg-vr self-assigned this Jul 27, 2023
@jorg-vr jorg-vr requested a review from a team as a code owner July 27, 2023 12:44
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team July 27, 2023 12:44
bmesuere
bmesuere approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test this easily?

@bmesuere bmesuere merged commit 9247754 into main Jul 28, 2023
@bmesuere bmesuere deleted the fix/question-state-reset branch July 28, 2023 08:41
@bmesuere bmesuere temporarily deployed to naos July 28, 2023 08:41 — with GitHub Actions Inactive
@bmesuere bmesuere temporarily deployed to production July 28, 2023 08:46 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niknetniko niknetniko niknetniko approved these changes

@bmesuere bmesuere bmesuere approved these changes

Assignees

@jorg-vr jorg-vr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delayed job to reset question state fails
3 participants
@jorg-vr @bmesuere @niknetniko