Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ufora LTI integration #4823

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Fix Ufora LTI integration #4823

merged 2 commits into from
Jul 12, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Jul 12, 2023

This pull request fixes the Ufora LTI integration.

The error thrown was: Authentication failure! invalid_response: NameError, uninitialized constant LTI::JWK::HTTPClient
I have no idea why it used to work before.

But it got solved by using the HTTParty gem - which we already required - to make the get request.

Tested on naos.

@jorg-vr jorg-vr added the bug Something isn't working label Jul 12, 2023
@jorg-vr jorg-vr self-assigned this Jul 12, 2023
@jorg-vr jorg-vr added the deploy naos Request a deployment on naos label Jul 12, 2023
@jorg-vr jorg-vr temporarily deployed to naos July 12, 2023 08:45 — with GitHub Actions Inactive
@github-actions github-actions bot removed the deploy naos Request a deployment on naos label Jul 12, 2023
@jorg-vr jorg-vr added the deploy naos Request a deployment on naos label Jul 12, 2023
@jorg-vr jorg-vr temporarily deployed to naos July 12, 2023 09:08 — with GitHub Actions Inactive
@github-actions github-actions bot removed the deploy naos Request a deployment on naos label Jul 12, 2023
@jorg-vr jorg-vr marked this pull request as ready for review July 12, 2023 09:15
@jorg-vr jorg-vr requested a review from a team as a code owner July 12, 2023 09:15
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team July 12, 2023 09:15
@jorg-vr jorg-vr merged commit e15bb41 into main Jul 12, 2023
@jorg-vr jorg-vr deleted the fix/ufora branch July 12, 2023 09:32
@jorg-vr jorg-vr temporarily deployed to naos July 12, 2023 09:33 — with GitHub Actions Inactive
@jorg-vr jorg-vr temporarily deployed to production July 12, 2023 09:36 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants