Check if course id is provided for series create #4617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
approved these changes
Jul 28, 2023
bmesuere
approved these changes
Jul 28, 2023
niknetniko
reviewed
Jul 28, 2023
| respond_to do |format| | ||
| if @series.save | ||
| if @series.course.present? && @series.save | ||
| format.html { redirect_to edit_series_path(@series), notice: I18n.t('controllers.created', model: Series.model_name.human) } |
There was a problem hiding this comment.
I am not entirely convinced this was the best solution, primarily because:
- We now do validation directly in the controller: the model itself should validate the presence of the course, not the controller.
- The check is done twice in the controller: once on line 111 and again on 117. I'm also not sure why 117 is necessary: if there are validation errors (as there are here, since we manually add them on line 114), the save method should not succeed.
Besides those, some more thoughts:
- This isn't something that this PR did, but why do we authorise here on the
Coursepolicy, instead of thecreate?method of theSeriespolicy (they seem to do the same thing)? Or, the other way around then, why is there acreate?method on theSeriespolicy if it isn't used here? - If we were to authorise on the
Seriespolicy, the crash would have also gone away, but the response would be 403 instead of 422. While maybe not the best response, it is more consistent with how we do it in other controllers (e.g. theevaluationcontroller) I think.
(The current code does work however, so this isn't very urgent)
There was a problem hiding this comment.
You're right, authorizing on series would make more sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests prevents series create from crashing when no course id is provided.
Closes #4147