Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check lower limit for memory_limit setting #4500

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

chvp
Copy link
Member

@chvp chvp commented Mar 21, 2023

Docker does not allow a limit below 6MB, which results in internal errors if people try to use one that low anyway.

  • Tests were added

@chvp chvp added the enhancement A change that isn't substantial enough to be called a feature label Mar 21, 2023
@chvp chvp requested a review from a team as a code owner March 21, 2023 12:45
@chvp chvp requested review from bmesuere and jorg-vr and removed request for a team March 21, 2023 12:45
Docker does not allow a limit below 6MB, which results in internal errors if people try to use one that low anyway.
@chvp chvp force-pushed the feature/check-memory-lower-limit branch from 9d907b5 to edc1065 Compare March 21, 2023 12:49
app/models/exercise.rb Outdated Show resolved Hide resolved
@chvp chvp force-pushed the feature/check-memory-lower-limit branch from ebe9bf0 to 8f3e86b Compare March 21, 2023 13:34
@chvp chvp requested review from jorg-vr and niknetniko March 21, 2023 14:55
@chvp chvp merged commit 7669014 into develop Mar 21, 2023
@chvp chvp deleted the feature/check-memory-lower-limit branch March 21, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants