Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preload the latest submission in the editor on the activity show page #4485

Merged
merged 11 commits into from
Mar 22, 2023
Merged

Preload the latest submission in the editor on the activity show page #4485

merged 11 commits into from
Mar 22, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Mar 16, 2023 •
edited
Loading

This pull request preloads the latest submission in the code editor. When this happens, an allert is also edit that explains what happened and allows the user to restore the boilerplate.

image
image

  • tests are added

Closes #2886

@jorg-vr jorg-vr added the enhancement A change that isn't substantial enough to be called a feature label Mar 16, 2023
@jorg-vr jorg-vr self-assigned this Mar 16, 2023
@jorg-vr jorg-vr marked this pull request as ready for review March 16, 2023 10:33
@jorg-vr jorg-vr requested a review from a team as a code owner March 16, 2023 10:33
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team March 16, 2023 10:33
chvp
chvp approved these changes Mar 16, 2023
View reviewed changes
app/views/activities/show.html.erb Outdated Show resolved Hide resolved
@jorg-vr @chvp
Update app/views/activities/show.html.erb
f96f8b8 
Co-authored-by: Charlotte Van Petegem <[email protected]>
@bmesuere bmesuere added the deploy mestra Request a deployment on mestra label Mar 17, 2023
@bmesuere bmesuere added deploy naos Request a deployment on naos and removed deploy mestra Request a deployment on mestra labels Mar 19, 2023
@bmesuere bmesuere temporarily deployed to naos March 19, 2023 14:21 — with GitHub Actions Inactive
@github-actions github-actions bot removed the deploy naos Request a deployment on naos label Mar 19, 2023
bmesuere
bmesuere requested changes Mar 19, 2023
View reviewed changes
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restoring now happens with a reload and a query string. It would be nicer for the user to do this with JS without reload.

@jorg-vr jorg-vr added the deploy mestra Request a deployment on mestra label Mar 20, 2023
@jorg-vr jorg-vr temporarily deployed to mestra March 20, 2023 08:49 — with GitHub Actions Inactive
@github-actions github-actions bot removed the deploy mestra Request a deployment on mestra label Mar 20, 2023
@jorg-vr jorg-vr requested a review from bmesuere March 20, 2023 14:22
@bmesuere bmesuere added deploy naos Request a deployment on naos and removed deploy naos Request a deployment on naos labels Mar 21, 2023
@bmesuere bmesuere temporarily deployed to naos March 21, 2023 14:37 — with GitHub Actions Inactive
bmesuere
bmesuere requested changes Mar 21, 2023
View reviewed changes
Copy link
Member

@bmesuere bmesuere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you impersonate me on naos, You'll see an error on https://naos.dodona.be/nl/courses/2026/activities/1944243494/

The console logs

caught SyntaxError: missing ) after argument list

@jorg-vr jorg-vr requested a review from bmesuere March 21, 2023 15:00
@bmesuere bmesuere temporarily deployed to naos March 21, 2023 15:25 — with GitHub Actions Inactive
@chvp chvp self-requested a review March 21, 2023 16:06
@bmesuere bmesuere temporarily deployed to naos March 22, 2023 08:20 — with GitHub Actions Inactive
@jorg-vr jorg-vr merged commit 2b60f04 into develop Mar 22, 2023
@jorg-vr jorg-vr deleted the enhance/preload-last-submission branch March 22, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chvp chvp chvp approved these changes

@bmesuere bmesuere bmesuere approved these changes

Assignees

@jorg-vr jorg-vr

Labels
deploy naos Request a deployment on naos enhancement A change that isn't substantial enough to be called a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Easy fetch last submission in hand in area
3 participants
@jorg-vr @bmesuere @chvp