Add tests for search components #4462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
requested review from
bmesuere and
niknetniko
and removed request for
a team
niknetniko
requested changes
Mar 15, 2023
test/javascript/components/search/standalone-dropdown-filter.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Niko Strijbol <[email protected]>
niknetniko
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds tests for multiple search components.
All these components now also take a
searchQueryobject as property. This makes it easier to test without a global searchquery state involved. It improves the reusability of these components, as this allows multiple searchcomponents belonging to a different query on the same page.