Merge pull request #4903 from dodona-edu/fix/activity-status-deadlocks

Allow more retries on activity_status deadlock errors

app/models/activity.rb

@@ -446,14 +446,14 @@ def activity_status_for(user, series = nil)
   end
 
   def activity_status_for!(user, series = nil)
-    first_try = true
+    tries = 0
     begin
       ActivityStatus.find_or_create_by(activity: self, series: series, user: user)
     rescue StandardError
-      # https://github.com/dodona-edu/dodona/issues/1877
-      raise unless first_try
+      # https://github.com/dodona-edu/dodona/pull/4903
+      raise unless tries < 3
 
-      first_try = false
+      tries += 1
       retry
     end
   end