Fix tests

dodona-edu · Dec 17, 2024 · d373898 · d373898
1 parent be4b3a9
commit d373898
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/test/system/activities_test.rb b/test/system/activities_test.rb
@@ -70,8 +70,8 @@ class ActivitiesTest < ApplicationSystemTestCase
   end
 
   test 'should not be able to submit to invalid exercise' do
-    @instance.update!(status: :not_valid)
-    visit exercise_path(id: @instance.id)
+    exercise = create :exercise, status: :not_valid
+    visit exercise_path(id: exercise.id)
 
     assert_no_selector '#editor-process-btn'
   end

diff --git a/test/system/scratchpad_test.rb b/test/system/scratchpad_test.rb
@@ -17,12 +17,6 @@ class ScratchpadTest < ApplicationSystemTestCase
     @course.series.first.activities << @exercise
 
     sign_in @zeus
-
-    # Open Papyros ready for use
-    visit(course_activity_path(course_id: @course.id, id: @exercise.id))
-
-    assert_selector '#scratchpad-offcanvas-show-btn'
-    find_by_id('scratchpad-offcanvas-show-btn').click
   end
 
   def codemirror_send_keys(parent, code)
@@ -41,6 +35,12 @@ def run_code(code)
   test 'Scratchpad can run code' do
     skip("This test fails infrequently, but i haven't figured out why yet")
 
+    # Open Papyros ready for use
+    visit(course_activity_path(course_id: @course.id, id: @exercise.id))
+
+    assert_selector '#scratchpad-offcanvas-show-btn'
+    find_by_id('scratchpad-offcanvas-show-btn').click
+
     ## Hello World!
     code = "print(\"Hello World!\")\n"
     run_code code