repurpose show/hide button

dodona-edu · Nov 5, 2023 · 78577e6 · 78577e6
1 parent 48cdfc9
commit 78577e6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/app/assets/javascripts/submission.ts b/app/assets/javascripts/submission.ts
@@ -46,12 +46,12 @@ function initSubmissionShow(parentClass: string, mediaPath: string, token: strin
                 tabButtons.forEach( b => b.classList.remove("active"));
                 button.classList.add("active");
                 if (button.dataset.show === "true") {
-                    tab.querySelectorAll(".group.correct").forEach((testcase: HTMLElement) => {
-                        testcase.style.display = "block";
+                    tab.querySelectorAll(".group.correct").forEach((group: HTMLElement) => {
+                        group.classList.remove("collapsed");
                     });
                 } else {
-                    tab.querySelectorAll(".group.correct").forEach((testcase: HTMLElement) => {
-                        testcase.style.display = "none";
+                    tab.querySelectorAll(".group.correct").forEach((group: HTMLElement) => {
+                        group.classList.add("collapsed");
                     });
                 }
             });

diff --git a/app/helpers/renderers/feedback_table_renderer.rb b/app/helpers/renderers/feedback_table_renderer.rb
@@ -154,10 +154,10 @@ def tab_content(t, tab_i)
               @builder << I18n.t('submissions.show.correct_tests')
             end
             @builder.div(class: 'btn-group btn-toggle') do
-              @builder.button(class: 'btn active', 'data-show': 'true', title: I18n.t('submissions.show.correct.shown'), 'data-bs-toggle': 'tooltip', 'data-bs-placement': 'top') do
+              @builder.button(class: 'btn', 'data-show': 'true', title: I18n.t('submissions.show.correct.shown'), 'data-bs-toggle': 'tooltip', 'data-bs-placement': 'top') do
                 @builder.i('', class: 'mdi mdi-eye')
               end
-              @builder.button(class: 'btn', 'data-show': 'false', title: I18n.t('submissions.show.correct.hidden'), 'data-bs-toggle': 'tooltip', 'data-bs-placement': 'top') do
+              @builder.button(class: 'btn active', 'data-show': 'false', title: I18n.t('submissions.show.correct.hidden'), 'data-bs-toggle': 'tooltip', 'data-bs-placement': 'top') do
                 @builder.i('', class: 'mdi mdi-eye-off')
               end
             end