Remove running of non-existent sql file. Add volume for needed shell script #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning for PR
Issues addressed:
pop_mini_RE.sql
was removed from gamerchanger-web in this commit. So it was removed from compose.generateCombinedEnv.sh
was not being copied into the container image for gamechanger-web and not volumed in. Added volume for the file in the docker-compose.Dockerfile.prod
in gamechanger-web?Question
Should gamechanger-data's default branch be
main
instead ofdev
?dev
seems to be 20 commits behindmain
. I can revert the repository url's and branches back to the original once (possibly changingdev
tomain
for gamechanger-data) the other PRs are merged into the appropriate branches.Accompanying PRs