This repository has been archived by the owner on Jan 24, 2025. It is now read-only.
fix(docz): use playground from context (fixes playground shadowing) #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerumen
reviewed
Oct 24, 2019
|
|
||
| return ( | ||
| <DoczPlayground | ||
| <components.playground |
There was a problem hiding this comment.
Maybe we can create a variable for this no? Makes it a bit clearer:
const components = useComponents()
const PlaygroundComponent = components.playgroundAlso the first !components is not necessary as there is already a default value here: https://github.com/jesperorb/docz/blob/6eda1289c872f891f58ac6e51c94d66938884294/core/docz/src/hooks/useComponents.tsx#L51
| @@ -0,0 +1,10 @@ | |||
| { | |||
There was a problem hiding this comment.
Thanks for catching that 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove docz-components and use Playground provided from gatsby-theme-docz via React Context