Merge inferred return type like we do for params. Refs #359 #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arv
reviewed
Nov 18, 2016
| type: flowDoctrine(fn.returnType.typeAnnotation) | ||
| }]; | ||
| var returnType = flowDoctrine(fn.returnType.typeAnnotation); | ||
| if (comment.returns) { |
There was a problem hiding this comment.
Do you need to check that returns is an array of at least one element here too?
There was a problem hiding this comment.
We won't get to this point if it isn't, since we return early on L20 if comment.returns.length is 0.
There was a problem hiding this comment.
Sorry, I don't see it. The early return happens if it is a non empty array with a type.
There was a problem hiding this comment.
Hm, good point. I'm not sure that that returns: [] ever happens in practice, but I'll add a guard here just to be sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.