Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split UI becomes pretty crazy when there's long content on the left #927

Closed
tmcw opened this issue Sep 26, 2017 · 0 comments
Closed

Split UI becomes pretty crazy when there's long content on the left #927

tmcw opened this issue Sep 26, 2017 · 0 comments

Comments

@tmcw
Copy link
Member

tmcw commented Sep 26, 2017 •
edited
Loading

image

no bueno

I think all this calculation should be replaced with a fixed 30/70 split. The left side should not ever have the ability to inhabit its natural width.
tmcw added a commit that referenced this issue Oct 12, 2017
@tmcw
fix: Fix the split in HTML at 33/67% instead of calculating percentages
56b2d55 
Previously this was calculated so that the left page would expand to its natural size. That's not
really what we want, because the natural size could be as high as 100%.

Fixes #927
@tmcw tmcw mentioned this issue Oct 12, 2017
Merged
@tmcw tmcw closed this as completed in #939 Oct 12, 2017
tmcw added a commit that referenced this issue Oct 12, 2017
@tmcw
fix: Fix the split in HTML at 33/67% instead of calculating percentag…
e4781eb 
…es (#939)

Previously this was calculated so that the left page would expand to its natural size. That's not
really what we want, because the natural size could be as high as 100%.

Fixes #927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmcw