-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge release 2.8.2 into 2.9.x #8485
Merged
greg0ire
merged 40 commits into
2.9.x
from
2.8.x-merge-up-into-2.9.x_602d59a0aa86b9.63081052
Feb 17, 2021
Merged
Merge release 2.8.2 into 2.9.x #8485
greg0ire
merged 40 commits into
2.9.x
from
2.8.x-merge-up-into-2.9.x_602d59a0aa86b9.63081052
Feb 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixed entity generation for numeric values * fixed entity generation for numeric values Co-authored-by: julian <[email protected]>
CS Batch 2/many
CS batch 3/many
Add docs to export-ignore
CS batch 4/an estimated 30
CS batch 5/an estimated 30
CS batch 6/an estimated 30
That comment is mistaken for a method comment because it precedes one. The issue was reported but will most likely not be fixed.
These files must be require'd
CS batch 7/an estimated 30
CS batch 8/an estimated 30
CS batch 9/an estimated 28
* Housekeeping: CS Query, AbstractQuery, NativeQuery. * Housekeeping: phpcs TreeWalker * Housekeeping: CS Doctrine\ORM\EntityManager * Housekeeping: CS Doctrine\ORM\Cache * Upgrade git-phpcs * Drop unused method parameter * Describe types more precisely Co-authored-by: Grégoire Paris <[email protected]>
CS Fixes 2 string interpolation to sprintf
CS batch 10/an estimated 27
* Ensure identifier type is set on deleteJoinTableRecords * Housekeeping: phpcs * Housekeeping: phpcs Co-authored-by: Benjamin Eberlei <[email protected]>
* [GH-8410] Fix memory leak in new toIterable and state bug. The new AbstractQuery::toIterable() had a memory leak that AbstractQuery::iterable() did not have. This leak is now fixed. After fixing the leak, one test failed where the identity map in ObjectHydrator triggered and lead to a notice. Introduced a new AbstractHydrator::cleanupAfterRowIteration() that the ObjectHydrator uses to cleanup the state. * [GH-8413] Bugfix: Iterating with multiple, mixed results When multiple entity results are part of a row, the result handling must be different. In addition mixed results with scalars are broken and now throw an exception as illegal operation. * Housekeeping: phpcs * [GH-8413] Add assertions for entity alias iteration. * [GH-8387] Missing @deprecated on Query::iterate
CS batch 11/an estimated 26
…2.9.x_602d59a0aa86b9.63081052
greg0ire
force-pushed
the
2.8.x-merge-up-into-2.9.x_602d59a0aa86b9.63081052
branch
from
February 17, 2021 19:39
70e3855
to
49864a7
Compare
greg0ire
approved these changes
Feb 17, 2021
greg0ire
deleted the
2.8.x-merge-up-into-2.9.x_602d59a0aa86b9.63081052
branch
February 17, 2021 19:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes for 2.8.2
2.8.2
Total issues resolved: 4
Total pull requests resolved: 10
Total contributors: 11
8467: [GH-8410] Fix memory leak in new toIterable and state bug. thanks to @beberlei and @simonberger
8448: Relax contract of EntityListenerResolver so it doesn't require class name thanks to @ostrolucky
8426: Fix --complete flag in orm:ensure-production-settings command thanks to @alexander-schranz
8412: fixed memory leak while iterating results thanks to @stlrnz
8392: [GH-8231] Bugfix: Missed dirty check synchronization check. thanks to @beberlei and @skurfuerst
Documentation
Bug
datetime_immutable
DBAL type for\DateTimeImmutable
instance parameters thanks to @vhenzl