Fix #7629 - scheduledForSynchronization leaks memory when using @ORM\ChangeTrackingPolicy("DEFERRED_EXPLICIT")

[yethee]

Fixes #7629

[Ocramius]

Possibly enough to call postCommitCleanup() internally there? Does the memleak appears also in non-empty UoW scenarios?

[yethee]

Possibly enough to call postCommitCleanup() internally there?

Yes, this should solve the issue. I can update PR. But method postCommitCleanup() has been absent in the master branch.

Does the memleak appears also in non-empty UoW scenarios?

I did not quite understand, that you mean on non-empty UoW scenarios? In theory, a next commit with changes (not empty) should reset scheduledForSynchronization.

Some info from debugging my app (used change tracking policy DEFERRED_EXPLICIT for all entities):

Chunk 1, before flush and detach (with exception of entities of EligibleAdGroup, they already detached):

Chunk 1, after flush and detach:

Chunk 2...

Chunk 3, before flush and detach:

Chunk 3, after flush and detach:

Commits (flush) for all chunks are empty - no changes.

[Ocramius]

Yes, this should solve the issue.

Then let's apply it here, and then we look for a solution for master.

[Ocramius]

I think patch looks fine as-is now, but we'll likely need a separate one (first commit only) for master, where we'll most likely need a separate approach.

[Ocramius]

This one is good to go as-is, thanks @yethee!