Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-8471] undeprecate partials completly #11647

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

beberlei
Copy link
Member

@beberlei beberlei commented Oct 9, 2024

This undeprecates SELECT PARTIAL DQL queries. EntityManager::getPartialReference is still deprecated, since it will be indistinguishable from EntityManager::getReference in the future.

Related:

@beberlei beberlei requested a review from greg0ire October 9, 2024 15:00
@beberlei beberlei changed the base branch from 3.2.x to 2.20.x October 9, 2024 15:00
greg0ire
greg0ire previously approved these changes Oct 9, 2024
@beberlei beberlei merged commit bea454e into doctrine:2.20.x Oct 10, 2024
75 checks passed
@greg0ire greg0ire added this to the 2.20.0 milestone Oct 11, 2024
@kevinpapst
Copy link

Probably not the best place, but I don't know where else:

This actually takes away a huge burden. I already invested many hours in replacing PARTIAL with the new fetchMode() but many use-cases were not covered and I wonder (and hope) that those are still on the roadmap ... but removing these specific deprecation actually improves my DX a lot.

Thank you 👍

@laufhannes
Copy link

Is it correct and wanted that the deprecation notice is still there in https://github.com/beberlei/doctrine2/blob/fc299b184b6c8e918ba08e4328687db126699ccd/src/UnitOfWork.php#L2991-L2996?

@greg0ire
Copy link
Member

Why are you linking to another repository than doctrine/orm?

@laufhannes
Copy link

Because I copied it from the merge request. Here you go: https://github.com/doctrine/orm/blob/2.20.0/src/UnitOfWork.php#L2991-L2996

@beberlei
Copy link
Member Author

@laufhannes good question, i need to look what the difference between HINT_PARTIAL and the HINT_FORCE_PARTIAL_LOAD constants are, I did not see this second location in createEntity during my PR, so its probably an oversight not to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants