Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation]: Query Result Formats: Minor #11359

Closed
wants to merge 1 commit into from

Conversation

ThomasLandauer
Copy link
Contributor

Page: https://www.doctrine-project.org/projects/doctrine-orm/en/3.1/reference/dql-doctrine-query-language.html#query-result-formats

I'd like to reorganize this section into a 3-columns-list, example:

Method Query constant Description
getResult() HYDRATE_OBJECT Retrieves a collection of objects ...

What do you think?

Page: https://www.doctrine-project.org/projects/doctrine-orm/en/3.1/reference/dql-doctrine-query-language.html#query-result-formats

I'd like to reorganize this section into a **3-columns-list**, example:
| Method | ``Query`` constant | Description |
|``getResult()`` | ``HYDRATE_OBJECT`` | Retrieves a collection of objects ... |

What do you think?
@greg0ire
Copy link
Member

I think it's a good idea. According to #11208, I think you should target 2.19.x.
What are you going to do with the note about array graphs?

ThomasLandauer added a commit to ThomasLandauer/orm that referenced this pull request Mar 17, 2024
Page: https://www.doctrine-project.org/projects/doctrine-orm/en/2.19/reference/dql-doctrine-query-language.html#query-result-formats

Follow-up of doctrine#11359

The table I suggested is probably not working, since the text for each method is too long. And what I really wanted is to make it more *scanable*. So I tried boldfacing - if this doesn't work, I'll try something else.

Questions:

1. This section here is basically the same as https://www.doctrine-project.org/projects/doctrine-orm/en/2.10/reference/dql-doctrine-query-language.html#hydration-modes ! So I'll try to merge them (in another PR), OK? I think the list is a better format (more scanable) - since those methods all work the same, there's no need for a full-blown code sample for each, IMO.

2. `getSingleColumnResult()` is missing.
@ThomasLandauer
Copy link
Contributor Author

Closing in favor of #11372

@ThomasLandauer ThomasLandauer deleted the patch-10 branch March 17, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants