Refator array_map into simple loop for performance #11332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beberlei
changed the title
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Mar 3, 2024
* 2.19.x: Refator array_map into simple loop for performance. (doctrine#11332)
derrabus
changed the title
|
ties a knot into his handkerchief |
|
Wouldn't it make sense to ban array_map with phpcs and remove all usage in all places of the code? I see it is used in SqlWalker, BasicEntityPersister, ReflectionPropertiesGetter, hydrators and other places |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to more complex performance refactoring in #11316
This already reduces performance overhead measured by Tideways by 56%. It shows again how expensive array_map is vs a simple foreach in performance sensitive code path.
Related to #11087