Deprecate invalid method call #11309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
deprecate-invalid-call
branch
from
a0cb310
to
bd9fb99
Compare
`getAssociationMappedByTargetField()` returns `null` when called with the owning side of an association. This is undocumented and wrong because the phpdoc advertises a string as a return type. Instead, callers should ensure they are calling that method with an inverse side. Closes doctrine#11250
greg0ire
force-pushed
the
deprecate-invalid-call
branch
from
bd9fb99
to
08d3f72
Compare
|
Does this require a change in the persistence contracts? |
|
I'd say it's more like we are getting in line with the persistent contracts: they say we should always return |
derrabus
approved these changes
Feb 26, 2024
|
Yes. We might want to look into adding native type hints to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getAssociationMappedByTargetField()returnsnullwhen called with the owning side of an association.This is undocumented and wrong because the phpdoc advertises a string as a return type.
Instead, callers should ensure they are calling that method with an inverse side.
Closes #11250